summary site project

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work on this one. Layout in general looks good, just the background needs to fix, site is responsive as well.

  Akshay already gave great feedback on this one, just going to add some suggestions as well:

  • It would be great to have a base styling of this:

  html {
    box-sizing: border-boxl
    font-size: 100%;
  }
  
  *,
  *::before,
  *::after {
    box-sizing: inherit
  }
  

  This way, handling an element specially its size will be easier because of the box-sizing

  • Always have a main element to wrap the main content of the site. For this use main tag on the .wrapper selector.
  • When using img tag, do not forget to add the alt attribute, whether the value is empty or not. Because by not including it, screen-reader will instead read the source path of the image which you don't want. So always include it.
  • The annual-plan should be using an h2 so that your heading tag usage will be proper and not skipping a heading level.
  • Lastly, just adding a padding to the sides of the body so that in mobile view, the layout won't be touching the sides of the screen.

  Aside from those, great job again on this one.

  Marked as helpful

  1
• 

  Akshay•810

  @akshaywebsterPosted about 3 years ago

  Hey, Vueko!

  Great work with the project!

  A couple of changes I would recommend:

  1. Your background svg isn't centered because you've done background-size: cover;, changing it to contain will make it look similar to the design file.

  2. Your card is not vertically centered.

  3. Also, you should add some box shadow to the card.

  Marked as helpful

  1