Skip to content
Submitted over 1 year ago

Summary order challenge

Sherif•150
@hikkenoace1
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

thoughts?

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HEADINGS ⚠️:

    • This solution lacks usage of <h1> so it can cause severe accessibility errors due to lack of level-one headings <h1>
    • Every site must want only one h1 element identifying and describing the main content of the page.
    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
    • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)
    • Example: <h1 class="sr-only">Order summary component</h1>
    • If you have any questions or need further clarification, you can always check out my submission for another challenge where i used this technique and feel free to reach out to me.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
  • _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    ➨ Remove all margins from the .container. To properly center the container.

    • USING FLEXBOX
    body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
    • USING GRID
    body{
min-height: 100vh;
display: grid;
place-items: center;
}

    ➨ Use Semantics for the proper design of your code.

    <body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
</body>

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful
    0
    Sherif•150
    @hikkenoace1Posted over 1 year ago

    i needed to make .container class because there was a different background for the body @NehalSahu8055

    0
  • _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    Also

    ➨ Every site must have one h1 element describing the main content of the page.

    • So, Add a level-one heading instead of <p> or <span> to improve accessibility.

    • <h1>Order Summary</h1>

    ➨ For an image like .svg are decorative which screen reader will not render it to be important and skip it, so it makes no sense to add alt leave it blank.

    ➨ Use <button> or <a> (if it is linking somewhere) for your proceed button. and given some opacity down on the hovering button as opacity:0.6.

    ➨ Use max-width instead of width to make your design responsive

    ➨ Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

    link.

    ➨ You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord