Design comparison
Solution retrospective
Was a very funny started project, when you more use flexbox you more understanding their use and is a lifesaver. I'm fascinating with Pure CSS. I think you can make amazing things with that. Talking about HTML I never get lost with tags because is easy to read.
Keep it going people!!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
DECORATIVE SVG'S ♨️:
- The
alt
attribute is used to provide alternative text for images in HTML documents. Thealt
attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
- Now, when it comes to decorative
SVGs
, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
- Since these images do not convey any important information or functionality, there is no need for an
alt
attribute.
- So feel free to set the
alt
attribute as""
for decorativesvg's
, becausealt=""
will be skipped by screen readers they will consider the image as decoration
Example:
<img src="images/decorative.svg" alt="">
<img alt="icon reaction" src="images/icon-reaction.svg"> 👇 <img alt="" src="images/icon-reaction.svg">
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @AbaljerindPosted over 1 year ago
Hi! Congratulations on your project. I just want to say don't ever give up on coding, even if right now we still have a lot to learn but of course we will get improve along with the time :D
For your project, i just want to say that you can still improve it using bootstrap to make the custom css more less and more easy to give style based on the design. Keep it up bro! Once again, congrats!!! :D
Marked as helpful0 - @AGutierrezRPosted over 1 year ago
Hello there 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
HTML:
- Instead of having a
div
with a class ofmain
to wrap the whole page, wrap the whole content in the<main>
tag. This challenge doesn’t have a header or a footer so you only need the<main>
tag. - You didn’t use BEM, but I like the way you structure your classes and the names
If you are using VSCode you could use
ctrl + shift + O
(if you are on windows) orcmd + shift + O
(if you are on MacOS) to travel through the file using the classes namesMarked as helpful0@davuboyPosted over 1 year ago@AGutierrezR Thank's for your suggest! i really apreciated your comment. Im going to keep improve my skills for doing the better way possible.
Greetings!!
0 - Instead of having a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord