Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS π¨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here π.
- For this demonstration we use css
Grid
to center the component.
body { min-height: 100vh; display: grid; place-items: center; }
- Now remove these styles, after removing you can able to see the changes
@media screen and (min-width: 1440px) { .main { padding: 15rem 15rem; } }
- Now your component has been properly centered
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@RaiRaiCidadePosted over 1 year ago@0xAbdulKhalid thank you, that will help me a lot βΊοΈ
0 - @firebird2552Posted over 1 year ago
I really like your solution. I used brighter colors in mine but your colors are closer to the original. I have a few notes... for your circle you need to set the width and height so that it is a circle yours is an oval. I set mine using .cirlce_class { height: 6rem; width: 6rem; border-radius: 50%; }
Second is the text at the bottom of your purple rectangle... it presses right up against the sides of box... you can fix this a few ways. you can add padding to the container which will push the edges away from the text you can use a margin or padding to create space around the text from all objects.
Other than these two things I think it looks really good.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord