Design comparison
Solution retrospective
My third challenge so far. Feel pretty good with flexbox, learned more about box-shadow, margins and paddings. Not sure if I used h1, h2, h3 tags properly please let me know!
Community feedback
- @SheGeeksPosted almost 2 years ago
Congrats on completing this challenge Kacper! A note for your question about headings, they should always be listed in order from
h1
down toh6
. Yourh3
tag for the result title should actually beh1
. The results count can be wrapped inh2
or you can wrap it in ap
tag and add a class in CSS to style it like a heading. Here's an class example:.result-count{ font-size: 2rem; color: #fff; /* any other styling you want */ }
Headings are labels for sections of a site and used to establish hierarchy with
h1
given the most importance. The title of a website is usually wrapped inh1
. However, article titles might be wrapped inh2
orh3
depending on other elements on the page. Bigger text does not always have to be a heading.I would also suggest using another measurement besides
vh
as your default sizing measurement for everything.px
,rem
, orem
, would be more appropriate. You want to use a measurement likevh
more intentionally, like when creating a hero section on a page and wanting it to take up the entire screen.Hope this feedback is helpful and congrats on finishing the challenge.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord