Design comparison
Solution retrospective
This was my first project done on my own. Any feedback always appreciated. Got a little confused about how to organize my css file and what classes, selectors etc. should I use.
Community feedback
- @MiculinoPosted almost 3 years ago
Congrats on completing the challenge on your own, @tobiasz121!
I had a look through your Github repo and final solution and I have a few suggestions that I hope will be useful to you:
-
Your card's dimensions are a bit too big
-
You used the wrong color for your button's box-shadow
-
You should more meaningful class names in your HTML
-
Add more classes in your code. There are a lot of HTML elements that don't have any class on them
-
No need to set a fixed height on the main element
Marked as helpful0 -
- @nikbosPosted almost 3 years ago
You can use <a> tag for Change and Cancel Order <button> for Proceed to Payment
Use @media
You use the wrong box-shadow color at line 170.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord