Design comparison
Solution retrospective
Responsive synthesis card developed with React JS, we implemented the reading of JSON data to display the title, icon, scores and corresponding media. It was a real challenge.
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @BadGuitarist07!
Your project looks great!
I have a couple of suggestions for improvement:
- First: I noticed that you used
position
to place the card in the middle of the page. It works fine, but it can cause bugs and part of your content can be cut off on smaller screens. So here's a very efficient way to center the card:
You can apply this to the body (in order to work properly, you can't use position or margins):
body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }
- Second: On desktop version, your card only has curved edges on the left side, so you have to apply it on the right side too.
I hope it helps!
Other than those details, you did a great job!
Marked as helpful0@BadGuitarist07Posted 11 months agoDear @danielmrz-dev
First of all, I appreciate you taking the time to analyze my work and share your recommendations.
I will be updating and implementing what you just shared with me. Thank you very much for your time.
1 - First: I noticed that you used
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord