Suite React Typescript Sass App

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Rio, very great work on this challenge! 😉 I was unable to take a closer look at the code in the repository as the ink is broken but...

  There are many ways to use svg with relative advantages and disadvantages and the correct use depends on the needs of the case:

  • insert it via an img element but you lose almost all the advantages
  • insert it in a css class in the content property so you can manipulate it at will
  • insert it directly into the html being able to manipulate it in various ways... the disadvantage is that often the svg code is very long and not very nice to see in the html

  Here are a few tips for improve your code:

  • add header tag and wrap the nav for improve the Accessibility
  • use transition on the element with hover effect
  • instead of using px use relative units of measurement like rem even for large dimensions such as containers
  • You can't add hover color status in icons using the img element... either you use a class containing the svg in the pseudoelement or you use the svg directly inside the html

  Overall you did well 😁 Hope this help!

  0