@gmagnenat
Posted
Hi, congrats on completing the challenge!
Here is a list of pointers you can check out to improve the accessibility of your solution:
- Use
<strong>
in your lists instead of the styledspan
. It has semantic meaning and is useful here to act like a label for the line. "total (the label): about 10 minutes (the description)." - It's correct to use a table, but tables have other elements such as
tr
,td
,th
, and more. Check them out to make it more semantically correct. - Use a modern CSS reset in all of your projects. Check out Josh Comeau and Andy Bell.
- Don't set a fixed width in pixels. Use a max-width and use
rem
. Currently, your solution doesn't scale if the user zooms because of this fixed width in pixels. It creates a bad user experience. - You should use relative units for everything related to fonts. Check out this great article to understand why: Why font-size must NEVER be in pixels
- Ideally, your media queries should use relative units such as
rem
as well, so your content can scale correctly if the user increases the system default font size.
I hope you find something useful in this list to improve the semantic structure of your solution and make it more accessible. Let me know if you need more explanation on any of the points.
Marked as helpful
@Jomagene
Posted
@gmagnenat
Wow! Thank you so much for your feedback and code review! Your insights were incredibly helpful, and I genuinely appreciate the time you took to explain everything so clearly. The resources you shared were fantastic, too! I’ve tried to implement all the details you pointed out—please take a look and let me know what you think.
What a comment! In just one comment, my understanding of responsiveness has almost doubled. Thanks again—I’m so grateful!