Styled with vanilla CSS (Flexbox)

Community feedback

• 

  Adarsh Pratap•5,515

  @adarshcodesPosted almost 4 years ago

  Hi @KristianDunne, Good work on this challenge👏. Your design is very similar to the original design and it's smooth as well.

  • As @daudi13, mention above about the overflow issue and the semantics, you can take care of those things.
  • And also while hovering on the button it scales up smoothly but on removing the mouse it scales down abruptly just because I think you forgot to add transition: property time - transition: all/transform .3s;
  • And also the responsiveness is working great.
  • With 0 HTML as well as an Accessibility issue. Keep it up👏. Happy Coding😀

  2

  ---

  

  Kristian Dunne•305

  @KristianDunnePosted almost 4 years ago

  @adarshcodes Thank you so much for taking the time to look at my code and visit the live site to spot these issues.

  I have now resolved these!

  0
• 

  David Ouma•270

  @daudi13Posted almost 4 years ago

  Hi Kristian, your code is clean and precise. the responsiveness is also good I just have two issues I noticed with your code. First I noticed you didn't use any heading and paragraph tags and secondly there is an hidden overflow on the content-box making the content incomplete on devices with smaller screens. Anyways keep up the good work. happy coding!!

  2

  ---

  

  Kristian Dunne•305

  @KristianDunnePosted almost 4 years ago

  Hey @daudi13 thanks for checking out my code and trying the site out on different screen sizes.

  I have a bad habit of not using sematic HTML markup, something I should really start doing - Using h/p tags around text as you pointed out.

  Nice catch on the overflow when on smaller screen sizes, will fix that.

  Thanks again!

  0