Student Testimonals with grid (Testimonals grid section)

Community feedback

• 

  P

  Koda👹•3,830

  @kodan96Posted 7 months ago

  hi there!

  I was looking at your code and noticed that the syntax you used for grid-template-rows and grid-template-columns is invalid, you can't do just (2, 4fr) there. Maybe you just left the repeat keyword out.

  I'd suggest you looking up the grid-template-areas property, it helped me a lot to visualize my grid and in my opinion it's the easiest way to set up grids like this. You can also view my solutions for challanges that required grid to complete, you'll see how the property works.

  Maybe I'm missing something, but generally it's not a good idea to set fixed height on your elements, especially if you are aiming to make responsive designs in the future. Your divs will adjust their height automatically to the content heigh, and you can work yourself up with margin and padding to achieve the desired outcome.

  Hope this helps, happy coding and good luck!

  Marked as helpful

  0

  ---

  

  P

  Manny Verma•230

  @mverma45Posted 7 months ago

  @kodan96 thanks for your feedback.

  0
• 

  Dan P.•250

  @DanielfwwPosted 7 months ago

  Hey Manny - Im looking at your project and l do see your blocks all over the place - and just to help you a little for example: If you are trying to use grid I would use display:grid and use grid-column-start to adress column or use grid-area to do row-start/column-start/row-end/column-end. The best way atleast for me is to look at the grid as almost like a chess board, and how much would you like to expand element - (where on the board would you like to put the element). In your example you dont really adress what grid supposed to do.

  .test2 {
  	position: relative;
  	background-color: #fff;
  	border-radius: 0.3rem;
  	/* overflow: hidden;
  	margin: 1.1rem auto; */
  	height: 25rem;
  	/* padding: 0.75rem; */
  	width: 24rem;
  	grid-column: 2;
  	grid-row: 1
  

  Hope this helps even a little.

  Marked as helpful

  0
• 

  P

  ikitamalarose•400

  @ikitamalarosePosted 7 months ago

  First congratulations for the effort and the work done. I invite you to take a look at my solution on this challenge in order to get an idea.But also to document yourself on the CSS Grid.

  Marked as helpful

  0
• 

  P

  Manny Verma•230

  @mverma45Posted 7 months ago

  Thanks @Danielfww and @ikitamalarose I will look into them

  1