Still learning how to use css properly

Community feedback

• 

  Tiass•295

  @TiasstiassPosted about 3 years ago

  Good job! 👏

  Nice work overall, some feedbacks:

  • You can use overflow: hidden for the card’s border-radius to work without setting it on the image as well,
  • The box shadow is really big on the button, a subtle 0 2px 5px #00000033 should work,
  • You can apply that shadow on the card as well,
  • Use more em and rem, especially rem for font-sizes. If you set a font-size on body and then rem on children, you could change all your font-sizes by just changing the body font-size and the children will scale accordingly.

  Keep up the good work 💪

  0

  ---

  

  iliwili•225

  @iliwiliPosted about 3 years ago

  @Tiasstiass Thank you very much for your feedback, I will add the changes later on!!

  0
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey, it means that the design screenshots that you got to work with were taken with those screen widths ^^ By the way great looking solution!

  0

  ---

  

  iliwili•225

  @iliwiliPosted about 3 years ago

  @FluffyKas Ow I see what you mean now, thank you very much!!

  0