stats-preview-card-component-main: using html and css

Community feedback

• 

  Bishal Mallick•115

  @bishalmallickPosted over 3 years ago

  no border, sizing is very small... use of overflow: hidden on the main card is a must use for this project... and background-blend-mode: multiply to apply desired overlay color to the image

  Marked as helpful

  2

  ---

  

  elasri21•1,390

  @elasri21Posted over 3 years ago

  @bishalmallick thank you so much for the feedback, i appreciate that

  0
• 

  Faris P•2,810

  @FarisPalayiPosted over 3 years ago

  Yeah, it really is.

  Some issues that I noticed:

  • You need to put a , between two font family names. For instance, in body tag, it should be 'Inter', sans-serif not 'Inter' sans-serif.
  • In the tablet version of the site(for eg:516px) the text is overflowing from the container
  • Also, there's deep nesting in the CSS selectors, it can make code maintainability harder than it needs to be. My suggestion is that, learn a naming convention like BEM to avoid that.
  • Furthermore, take a look at HTML Semantics

  That's all for now. Have fun coding ✨

  Marked as helpful

  1

  ---

  

  elasri21•1,390

  @elasri21Posted over 3 years ago

  @FarisPalayi thank you so much for the feedback, i appreciate that

  1