Design comparison
Solution retrospective
Please check my code, and tell me what I should improve.
Community feedback
- @FarisPalayiPosted over 3 years ago
Looks nice and responsive π
A few suggestions are:
- Set the image's alt tag to
alt=""
since the image here doesn't provide any extra context or info to users. And so that assistive devices can ignore them. - Try using a smaller media query breakpoint because, even though currently I'm using my laptop to see your solution, I'm getting the mobile version of the site.
- Also, on mobile, the attribution text is on top of the card, so try to change it if you canπ
That's all from me. Have fun coding β¨
Marked as helpful1@leonardo9245Posted over 3 years ago@FarisPalayi Hi, thanks for your feedback, I made the changes, could you check again?
thankful
1@FarisPalayiPosted over 3 years ago@leonardo9245 Looks greatπ and layout is responding really well. Well done π
btw, the
font-family
of the text under stats(for eg: "companies") islexend deca
notInter
πOne more suggestion would be to change those h2 tags to
<strong>
or<span>
because those are technically not heading for anything. Take a look at Semantic HTMLAs always, have fun coding π
1 - Set the image's alt tag to
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord