stats-preview-card-component-main

Community feedback

• 

  Alan•160

  @TheMax370Posted about 2 years ago

  Hi Vishal congratulations on completing this challenge, but I want to give you some advices that will help you to do your challenges more responsive:

  • I strongly recommend that in future challenges you use semantic HTML because its going to help other developers read and understand your code more easily. Also I see that you are using a div tag as a main when you could achieve the same purpose with a <main> tag.

  • Instead of using translate property learn how to use justify-content and align-items when setting a container to display: flex;

  • In both classes head and head1 instead of using a div tag learn how the use case of a span tag that will accomplish better when trying to style specific elements.

  • I recommend you to use a better name conventions for your classes you could look in google about BEM for example.

  • To make your code more readable I strongly suggest to put your code in a .css file and learn how to use the link tag element.

  • Another recommendation dive deep in responsive design (flex, grid, relative lengths, etc...) this will help you a lot in future challenges

  I hope these points will help you in the future and don't worry the more you challenges you make the better you will become.

  Marked as helpful

  0

  ---

  

  vishal sharma•170

  @princechamp07Posted about 2 years ago

  @TheMax370 Thanks you so much for giving such a beautiful advice this will help me a lot in future i will take care of all the things you mentioned and make it more readable for other developers. Thanks once again for giving your time to provide this feedback.

  0