Vanza Setia• 27,795
@vanzasetia
Posted
Hello, Nida! 👋
Congratulations on finishing this challenge! 🎉
I have some feedback on this solution:
- Accessibility
- All the page content should live inside landmark elements (
header,main, andfooter). By using them correctly, users of assistive technology navigate the website easily. In this case, wrap all of it withmaintag,except the attribution. The attribution should be lived inside thefooter.
- All the page content should live inside landmark elements (
<body>
<main>
page content goes here...
</main>
<footer class="attribution">
attribution links goes here...
</footer>
</body>
- Like @david-oncu has said earlier, don't skip heading level.
- Also, the stats number should not be a heading. The content below it is too small. You might find it helpful if you think of a heading like a title on a document.
- Use CSS to uppercase the text. The uppercased word in the HTML will be spelled by the screen reader (spelled letter by letter).
- Good job on leaving the
altempty for the decorative image! 👏 - Use
remor sometimesemunit instead ofpx. Usingpxwill not allow the users to control the size of the page based on their needs. - Styling
- Use flexbox to make the card centered both vertically and horizontally.
- I notice that you have imported all the font-weight for each font family and that makes your site load so slow. I would recommend only importing the necessary font weight for each font family.
color: hsla(0, 0%, 100%, 0.75);;There are double semi-colons on line 66 in thestyle.css.- Adjust the breakpoint of the media query. Two columns layout at 600px width is too early.
- Best Practice (Recommended)
- I would recommend writing the styling using the mobile-first approach. It often leads to shorter and better performance code. As a result, mobile users will no longer be required to process all of the desktop styles.
That's it! Hope you find this useful! 😁
Marked as helpful
0
Nida Ismail• 70
@nidaismail
Posted
@vanzasetia Thank you so much for such brief and comprehensive feedback I really appreciate it and of course, it's very helpful and productive.
0
Vanza Setia• 27,795
@vanzasetia
Posted
@nidaismail You're welcome! 😄
0
