stats-preview-card-component-main

Community feedback

• 

  Rohit Deshpande•870

  @rohitd99Posted over 1 year ago

  Hi Othman

  Congrats on completing the challenge.

  Firstly you have kept the title as a h2 heading but it must really be a h1 heading. Each page must have a single h1 heading signifying the page title. Also headings must always be from h1 through h6 in order. These are mainly for semantic reasons and SEO. Secondly the header image can be a background image since it has no specific meaning. Other than these a really nice solution.

  Hope it helps

  Marked as helpful

  0

  ---

  

  Othman•380

  @Rizqy777Posted over 1 year ago

  @rohitd99 Thanks for your advice, the reason why I used an "h2" instead of an "h1" is because I imagine that this card would be part of a web page that would have an "h1", but you are right, I will change it, thank you.

  0

  

  Rohit Deshpande•870

  @rohitd99Posted over 1 year ago

  @Rizqy777

  I see, if it were a part of another page and was like a component then h2 might have been the right choice and if it is on it's own page then h1 would be the correct one.

  0