Design comparison
SolutionDesign
Community feedback
- @frank-itachiPosted over 1 year ago
Hello there π. You did a good job!
I have some suggestions about your code that might interest you.
HTML π:
- Get rid of the
class="container card"
of the main tag. The HTML document should have only one<main>
tag so it is not necessary to classify it. - The heading order is important in the html structure so try to always start your headings and/or titles with an
<h1>
tag and then you can increase by one if you need to use more headings in your html code. So replace the<h2 class="content-title">
by the<h1>
tag. - Wrap the
<div class="attribution">
element inside the<footer>
tag.
I hope you find it useful! ππ Above all, the solution you submitted is greatπ!
Happy
<coding />
π!Marked as helpful0 - Get rid of the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord