Design comparison
Solution retrospective
Any HTML structure or CSS styling criticism is welcome
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @UnderdogScripter 👋🏻
I have some concerns and suggestions for the project
- Well, my only concern with the project is that it neither shows the heading nor the text underneath it. I'm not sure if you're still working on it or making some changes, but please take a look at it.
- Next, I'd suggest putting
.attribution
at the bottom of the page and put it in<footer>
tag, since it's the project's footer.
I hope this was helpful 👨🏻💻 once you fix those, me and other mentors can give more detailed feedback. Cheers 👾
Marked as helpful1@UnderdogScripterPosted about 3 years ago@kens-visuals Didn't quite get what you mean by the first suggestion? Do you mean I'm not using headings? Explain more please, thanks!
0@kens-visualsPosted about 3 years agoHi @UnderdogScripter, yeah sure. Check this link out, that's what I see and other users see. That's what I mean when I say I there's no heading or paragraph.
0@UnderdogScripterPosted about 3 years ago@kens-visuals Why is that? I can clearly see it from the live site URL, did you try multiple times?
0@kens-visualsPosted about 3 years ago@UnderdogScripter I just tried to open it on Safari and Chrome, it works. But, it doesn't work on Firefox.
1@UnderdogScripterPosted about 3 years ago@kens-visuals That's really weird, any idea why?
0@kens-visualsPosted about 3 years ago@UnderdogScripter frankly, I have no clue. Nothing similar has ever happened to me, all I know is when I open the dev tools
.advertise
is just gray and doesn't change anything when I toggle the styles.0@UnderdogScripterPosted about 3 years ago@kens-visuals I just opened it with Firefox Developer Edition and it works absolutely fine, maybe try to update your browser? (the idea of this not working on some browsers is bugging me out lol.)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord