stats_preview_card_component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Tenzin! 👋

  Congratulations on completing this challenge! 🎉

  I notice that the card turns into a two-column layout on 376px width. As you may already know that the card doesn't have enough space to become a two-column layout at 376px width. So, I would recommend adjusting the breakpoint for the media query.

  A few more suggestions.

  • For handling the image-header, I suggest using picture element instead. It will allow you to decide which image should appear based on the user's viewport width.
  • For the statistic, I would recommend making it one list. If the site has no styling then it would render it as follows. Also, this is how the screenreader would "see" the list.
    • 10k+ companies
    • 314 templates
    • 12m+ queries
  • In your CSS, I noticed this selector .component .proj-prev .table which would much be as .table . I would recommend only nesting when you want to style pseudo-elements, pseudo-classes (:hover, :focus, etc), and @media queries. It's a good practice to keep the CSS specificity as low and flat as possible. High specificity will make your stylesheet hard to maintain.

  I hope this helps! 😁

  Marked as helpful

  0

  ---

  

  Tenzin•140

  @lekdupPosted over 2 years ago

  @vanzasetia thank you very much Vanza, i will get right on it!

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @lekdup No problem, Tenzin! 👍

  0