Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace<div class="main_container"> with the main tag, <h3> with <p> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
Add the alt attribute
alt=" "
to the img tag and give it a value to fix the error issue. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.For the color of the image:
- In the mobile design, give .mobile-image a background-color of soft violet, background-blend-mode: multiply and opacity: 0.8.
.mobile-image{ background-image: url(); background-size: cover; background-color: hsl() background-blend-mode: multiply; opacity: 0.8; }
- in the media query, give .desktop image a background-color of soft violet and give the img a width and height of 100%, object-fit: cover , mix-blend-mode: multiply and opacity: 0.8.
.desktop-image{ background-color: hsl(); } img{ width: 100%; height: 100%; object-fit: cover; mix-blend-mode: multiply; opacity: 0.8; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord