stats-preview-card-component

Community feedback

• 

  Ramy Ibrahim•105

  @RamyEbrahimPosted over 3 years ago

  well done :)

  0

  ---

  

  Rabah•380

  @rabahmilanoPosted over 3 years ago

  @RamyEbrahim Thank you

  0
• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  Hi @rabahmilano! Well done on this challenge, it looks great! I only have two (really minor) comments:

  • on very small mobile screens, the image doesn't fully cover the container. Not a massive issue, but you could easily fix that by changing background-size to cover.

  • I think the stats part could be a ul here - but again, not a massive issue, but it's good to use semantic HTML where it makes sense :)

  Again, nice work!

  0

  ---

  

  Rabah•380

  @rabahmilanoPosted over 3 years ago

  @AgataLiberska Thanks for your review, I really appreciate it. I just fixed the issues you mentioned, and now it looks pretty good. I am open to all other suggestions.

  0

  

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  @rabahmilano Just had a look, looks good :) there is a property you could've used to get the overlay effect instead of a color with less opacity - background-blend-mode. I personally prefer the colors in your solution but it could get you closer to the design (although I'm not totally certain, I haven't done that challenge yet :))

  1

  

  Rabah•380

  @rabahmilanoPosted over 3 years ago

  @AgataLiberska To be honest, it's the first time that I use this css property, and I found it pretty good and it makes me closer to the design like you said. Thank you very much for your help

  0