Design comparison
Solution retrospective
Qualquer feedback sobre o projeto serΓ‘ apreciado.
Community feedback
- @HassiaiPosted over 1 year ago
To center the main on the page using flexbox, replace the height in .container with min-height: 100vh. There is no need to give .container a width value.
USING FLEXBOX: .container{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
For the color of the image. Give .imagem a background-color of soft violet, and the img a width and height of 100%, mix-blend-mode: multiply, object-fit: cover and opacity: 0.8.
.imagem{ background-color: hsl(); } img{ width: 100%; height: 100%; object-fit: cover; mix-blend-mode: multiply; opacity: 0.8; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
You forgot to add a media query for the mobile design. For more on media queries, click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div class="attribution">
with semantic element<footer>
to improve accessibility and organization of your page.
- Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections
I hope you find it helpful ! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord