Design comparison
Solution retrospective
For this challenge I really got into the responsive design world, it was hard to get it working and might be better, I'll keep practicing to get it right.
Leave a comment if you wanna provide feedback! Thanks!
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Buddy, Well done! you did it and you tried you best and also learnt alot.
Your desktop design is ok. Even you make it responsive but in media query you have not gave top margin which result your whole layout is out of viewport.
Fix your media query.
Good Luck For Next Challenge
Marked as helpful1@diegop985Posted almost 3 years ago@skyv26 Hey Aakash thank you so, so much for your feedback, it was indeed very helpful for me, I didn't noticed the margins were collapsing. The margins collapsing is a whole thing but I managed to fix it using display: flow-root;.
Thanks!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord