stats-preview using flex

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="card">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  There is no need for the <br> in the html.

  Give the alt attribute in the img a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  There is no need to style .card . To center .container on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  USING FLEXBOX:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  USING GRID:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  For the color of the image add mix-bled-mode: multiply and opacity:0.8 to the img.

  .img{
  background-color: hsl();
  }
  img{
  width: 100%;
  height: 100%;
  object-fit: cover;
  mix-blend-mode: multiply;
  opacity: 0.8;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  1

  ---

  

  Islam abozeed•240

  @islamabozeedPosted over 1 year ago

  @Hassiai woooooooooooow, that was awesome comment I've ever seen here, impressive now I see how to get the font, I was doing it with luck ^^ now i'm studying each part of your review,

  I used <br> to make 2 rows of text to be similar is task, and yeah would better if i use flex and justify-content.

  was funny that i was not sure of using font ( font-family, font-size) still the height and width without any guide yet, perhaps there is something for it.

  also img code it woooooooow, it works and amazing :D :D thanks a bunch

  0