Design comparison
Solution retrospective
Hey everyone!! I've already done this challenge, and now I've done this challenge again refactoring my code and fixing image issues. This challenge seemed easy but it's tricky. I got to know some basic fundamentals by taking up this challenge You can compare my both codes on this challenge.
Community feedback
- @mscatesPosted almost 3 years ago
Hello Priyanka, one thing I see is that your flex-container does not have a max-width so on a large screen your card is really big. what you could do is give it a max-width of say 1000px and then set each child of the container to flex: 1 so that each takes up exactly half the space. it will be more uniform that way. your mobile view is very good. great job.
Marked as helpful0@priyankavasam7Posted almost 3 years ago@mscates Hello Mark, Thankyou for your feedback. I will try it out. I really faced difficulty while designing for desktop regarding this flex-container, I didn't really understand how to set flex properly. But now I got idea and I will definately try that out. Thankyou for helping me in this!!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord