Design comparison
SolutionDesign
Solution retrospective
Suggestions/ Guidance welcome
Community feedback
- @A-amonPosted over 3 years ago
Hello! Great job~ The responsiveness looks good. Aside from what's been suggested above, I would suggest:
-
Try using picture tag for .desktop-img and .mobile-img. It lets you switch between both pictures responsively.
-
Your design pics are not in your github .repo. Hence, it doesn't show up on the readme section.
Two solutions submitted in one day- Keep up the efforts! :)
Marked as helpful0 -
- @IEdiongPosted over 3 years ago
Nice one 👍
Some suggestions:
- change the
font-family
on the<h3>
toInter
- use
<h1>
in place of the<h3>
. This is to solve one of the accessibility issues - use semantic tags like
<main>
,<footer>
,<article>
,<section>
,<ul>
etc to wrap around your elements, defining their meaning - add some spacing around the
.card
, it's too close to the edge at smaller screen sizes - work on the design at
800px
screen size - lastly, look into the other accessibility issues raised above in the report.
I hope this was helpful, Cheers 🥂
Marked as helpful0@IEdiongPosted over 3 years ago@Anitha-vpk I'm glad I could be of help 🤝
0 - change the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord