Design comparison
Solution retrospective
It felt like I was over doing it with a bunch of extra height, max-height, width, max-width, and funky margin vs padding work arounds. Wasn't entirely certain how to clearly fix it properly, but did get everything to work.
From a Jr CSS dev, it seems this is the way to do thing, but I think seasoned professional CSS devs would do this differently.
I greatly appreciate any and all feedback how I can improve.
Thank you in advance for your time and feedback you can give on my solution.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @W4GFO, congratulations on your solution!
Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:
To get closer to
overlay effect
on the photo as the Figma Design its better you usemix-blend-mode
. All you need is thediv
under theimage
with thisbackground-color: hsl(277, 64%, 61%);
and applymix-blend-mode: multiply
andopacity: 80%
on theimg
orpicture
selector to activate the overlay blending the image with the color of the div. See the code bellow:img { mix-blend-mode: multiply; opacity: 80%; }
Here's a good article explaining these effects with mix-blend-mode:
https://developer.mozilla.org/en-US/docs/Web/CSS/mix-blend-mode
✌️ I hope this helps you and happy coding!
0@W4GFOPosted about 2 years ago@correlucas Hello Lucas, Thank you for taking a look at my project and for the help and super useful link. I will use what you laid out here in all my future projects. Thank you again.
Jeff
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord