Skip to content
Submitted over 1 year ago

Stats preview

timidij•220
@timidij
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Stats preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Feedback are welcome, I am having a challenge applying color over the image, any solution?

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage
    • So fix it by replacing the element <div class="attribution"> the with semantic element <footer> in your index.html file to improve accessibility and organization of your page.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
    • They convey the structure of your page. For example, The <footer> typically contains information about the author of the section, copyright data or links to related documents.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    0
  • C H A R A N 🎯•2,670
    @0xabdulPosted over 1 year ago

    Hello there well congrats on completing the Stats preview card component ...🎉

    • A Few feedback for you improve your code Html 🏷️:
    • the html page Must be contain one main landmark
    • for Accessibility reports using the non-semantic elements (or) semantic elements..
    • semantic elements : <aside> , <artical> , <main>, <header> ,<section><footer>, <form> ect..
    • non- semantic elements : <div> , <span> ect ...
    • for easy way to clear the Accessibility reports using non semantic elements Ex :
    <body>
<div class="container" role="main">
/html code goes here : 🏷️
</div>
</body>
    • Or
    • using semantic elements
    • Ex :
    <header>
should be put heading or logo
</header>
<main>
Main of the contents 
</main>
<footer>
©copy right  here
</footer>
    • In Css 🎨 :
    • your Stats preview card component is not center aligning so fix this
    • Ex :
    body {
display :grid;
place-items: center;
margin:0;
height:100vh;
}
.image img{
opacity:0.6;
}
.image{
background-color:hsl(279 , 98% , 45%);
}
    • I Hope it's useful for you
    • Happy Codingtimidij🤩
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord