Stats Preview - CSS Grid and Flexbox - First Attempt

Community feedback

• 

  T

  Grace•31,090

  @grace-snowPosted about 3 years ago

  Overall, really great job here. The only things I’d change are

  • <div class="container" role="main"> there is never a reason to use role when you could use the real main element
  • content is hitting the screen edges on my mobile. Either add a little margin to the sides like you have to the top and bottom, or add a little padding to an outer wrapper
  • the attribution footer is overlaying the card content on mobile. No need to display it absolutely, just let it sit at the bottom

  Well done and have fun on the next one 👍

  Marked as helpful

  1

  ---

  

  P

  Arjen Combee•50

  @ArCombeePosted about 3 years ago

  @grace-snow Again, thanks for your feedback. And yes, on one of my phones I see the same issue, will make a revision on this part. The footer thing was a copy from other project and should not be applied like this. Need to learn to up my quality in the details. This point is clear from the feedback (which I really appreciate) 😀 and part of my next project... A developer has so many things that can go "wrong"... this is a real eye-opener in the 3 projects I did so far. A big shout out to all (pro) developers for their professionality and great results on their projects, can imagine the struggles they have in their day job 😀. Hope I will adapt the steady and coherent workflow in the future, where the quality is key of course.

  Overall I'm happy with the results of the projects so far but most important I had a lot of fun in doing the projects and refactor them with the feedback I receive.

  ---

  Arjen Combee

  0