Design comparison
Solution retrospective
This my submission. I need help with the overlay and media queries. Thank you
Community feedback
- @EngineerHamzieyPosted over 2 years ago
Asalamu aleykum warohmotullohi wabarokaatu sister, May Allah crown our effort with success.
Here are my suggestions concerning the accessibility issues
- Always add the language attribute to your <html> tag, i.e it should look like
<html lang="en">and here en means English. - All page content should be contained by landmarks, like Header, footer, main, aside.....so Instead of
<div class="container">you should use<main class="container">And your .attribution should be inside the footer tag
and I noticed a lot of other errors , so if you don't mind, there are more explanation here on how I did mine after being corrected by mine dearest mentors. The code contains alot of comments which are explanations to how and why everything is done in the code
I hope you found this helpful 😊
Marked as helpful1@BAderintoPosted over 2 years ago@EngineerHamziey I am so grateful. I knew there are so many flaws in my project but I was determined to get help by submitting it first. I want to be original enough to make mistakes. Thank you so much
1@EngineerHamzieyPosted over 2 years ago@BAderinto yes that's a wise decision that's a good way to learn. If you check my profile, you will see I also.... 😊
Marked as helpful0 - Always add the language attribute to your <html> tag, i.e it should look like
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord