Design comparison
Solution retrospective
All feedback is welcome thank you in advance.
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨For
non-decorative images
give meaningful and descriptive alt likealt= "Three Women engaged in their work"
.➨ Replace
min-height: 93vh;
withmin-height:100vh;
to properly center the card.➨
<footer>...</footer> wrap up .attribution div inside footer for proper sematics.
➨ Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.link.
➨ You can use
accessibility features
likearia, sr-only, and title
which are accessible to screen readers.I hope you find this helpful.
Happy coding😄
1@Rahimi1197Posted over 1 year ago@NehalSahu8055 Hi, Thank you for your guidance. It was very useful for me :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord