Stats preview card using HTML, Sass and Bootstrap
Design comparison
Solution retrospective
What do you guys think about the responsiveness? What do you think about the visual aspect of the page? does it look good? What are some practices that you think can be improved?
Community feedback
- @PeshwariNaanPosted over 2 years ago
Nice job Ricardo. One thing that I think will help you is how to make the image responsive. Create a <div> container that will hold your image -
<div class="image-container"> <img class="image" src="./whatever"> </div> -Once you have this add this code to your .image scss code: .image { max-width: 100%; max-height: 100%; object-fit: contain; overflow: hidden; } This will force the image fill the container and change responsively and keep its aspect ratio. I hope this helps.
Marked as helpful0@RicardoFuentes437Posted over 2 years ago@PeshwariNaan Thank you very much for your feedback, making the image responsive was one of the hardest things for me in this challenge, this is really helpful, thank you again :)
0 - Account deleted
Buen trabajo!! 🎉 Tengo algunas sugerencias:
div class='image-section'
puedes cambiarlo por unfigure
para que sea más semántico.- Tienes
h2
pero no unh1
. Recuerda todo HTML debe tener unh1
, para la accesibilidad. - Considero que las estadísticas son una lista desordenada:
ul class="stadistics"
,li class="heading-stats number"
Puedes visitar mi solución a este challenge 👉 aquí. Espero haberte ayudado, sigue así 💪💪
Marked as helpful0@RicardoFuentes437Posted over 2 years ago@irismendez Muchas gracias por el feedback :) no conocía el tag figure pero ahora definitivamente lo utilizaré en mis proyectos.
Saludos.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord