Design comparison
SolutionDesign
Solution retrospective
-I had little bit trouble making the overlay of the image. I made it but I'm not sure if it's correct or not. -I started making the desktop design and then I tried to make it responsive for mobile. I struggle with this part so I'm sure that what I did is wrong, so any feedback is welcome!!
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Marina, It looks good!...
My suggestions:
Document should have one main landmark
, Contain the component with<main>
.
<main> <div class="container"> //... </div> </main>
- An easy way to color the image...
First, Delete this element --->
<div class="overlay"></div>
, then give the wrapper of the image(#box-2
)background color
to blend it with the image:
#box-2{ //... background-color: #aa5cdb; /* <---- Add */ } #box-2 img { //... mix-blend-mode: multiply; /* <---- Add to blend with the content of the element's parent and the element's background.*/ opacity: 75%; /* <---- Add */ } #box-2 .overlay { /* <---- Remove */ //... }
- I suggest you center the component on the page with
Flexbox
, by giving the parent element.container
the following properties:
.container{ display: flex; justify-content: center; /* margin-top: 230px; <---Remove */ align-items: center; /* <---- Add */ min-height: 100vh; /* <---- Add this to center the component at this height */ }
h1
orp
element is not allowed to use insidespan
instead, I suggest you put the status of the preview card component into thelist item
to add moresemantics
to your project.
<ul class="stats-preview__stats"> <li> <span class="stat-number">10K+</span> <span class="stat-name">Companies</span> </li> <li> <span class="stat-number">314</span> <span class="stat-name">Templates</span> </li> <li> <span class="stat-number">12M+</span> <span class="stat-name">Queries</span> </li> </ul>
Hope this help!... Keep coding👍
Marked as helpful0@hellomarinaPosted over 2 years ago@Bayoumi-dev Thank you so much for your feedback! I already made the changes and I will make sure to practice more. Thank you again for taking time to explain me, I really appreciate it :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord