Design comparison
Solution retrospective
Please review the solution. Suggestions, comments, feedbacks and recommendations are welcome.
Community feedback
- @CyrusKabirPosted about 3 years ago
hello my dear friend ♥ your project it's good and clean but here some little problems :
- try use more semantic elements like <main>,<footer>,<section>,etc.
- the "m"&"k" in numbers should be uppercase at last everything was fine and i wish you good luck and go ahead for more challanges ♥♥♥
Marked as helpful0 - @Juveria-DalviPosted about 3 years ago
hey.. the accessibility issue says that you should have wrapped all divs in <main> which is the semantic tag ,except for the div with class attribution that should be wrapper in <footer> tag for more details refer w3school.com
Marked as helpful0 - @ted-dinoPosted about 3 years ago
Hi Shivang, I'm a newbie and also learning here in Frontend Mentor I just want to share what I see on your code. I notice in your styles.css you have a multiple of @media (min-width 50em). I think your css will be more organized if you put them in one @media (min-width 50em) other than that it's nice and it also looks good on mobile. Keep up the good work and try to fix the accessibility issues. Have a great day!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord