Stats Preview Card Project

Community feedback

• 

  Mike Stop Continues•100

  @mikestopcontinuesPosted 11 months ago

  Hey, you got this really close to the design. Nicely done.

  Here's some thoughts I would offer as a lead dev on your team:

  1. Designers are very picky about their designs. Can you update your design so that the overlay color is closer to the design?
  2. I think the design gets responsive too early. It should collapse for mobile only when the browser window is very close to the component. Use the padding from the mobile design image as a guide.
  3. I notice your HTML can be a bit more semantic. This widget would only be part of a larger design, so it should be a section, not an article. (Articles are for long content, or for excerpts of long content.) Similarly, you wouldn't use section within a section. The inner sections should be plain divs. Lastly, it's best practice to never skip heading levels. Where you have h1, I would use h2. After all, this would be part of a larger web page, and the full page will have an h1 for everything.

  Marked as helpful

  0

  ---

  

  Nate Pañares•150

  @ShinjiX-WebPosted 11 months ago

  @mikestopcontinues thanks for the feedback. Helpful one Cheers!

  1