@vanzasetia
Posted
Hello, Ernest! π
Great work on this challenge! Your solution looks pretty good! π
There are some areas that you could do to improve this solution,
- I would recommend increasing the breakpoint of the media query because it's too early to make the layout into two columns. On mobile landscape 360px * 640px, the layout becomes the two columns layout or the desktop layout.
- In your CSS, I noticed this selector
section article.stat-number h2
which would be much be asstat-number-heading
. I would recommend only nesting when you want to style pseudo-elements, pseudo-classes (:hover
,:focus
, etc) and@media
queries. It's a good practice to keep the CSS specificity as low and flat as possible. High specificity will make your stylesheet hard to maintain. - In addition to the previous point, the stat number should not be a heading, it should be a paragraph because the content below it is too small. You might find it helpful if you think of a heading as a title in the document.
- I would recommend making the stats as a
ul
instead of asection
and wrapping each stats item withli
. Usingsection
andarticle
too much might cause a lot of noise for users of the screen reader.
I hope this helps! Keep up the good work! π
Marked as helpful
@gbabohernest
Posted
@vanzasetia thanks for so much for the feedbacks. I wil do my best to keep things simple in my code. Thanks a lot. π