Design comparison
Solution retrospective
i am facing problem with responsive height of card. how i can solve this. though somehow i mannaged to done this project. but i am not satisfy with that. tell me how i can can improve this project
Community feedback
- @shashreesamuelPosted over 2 years ago
Hey khshakib good job completing this challenge. Keep up the good work
In terms of your solution, it looks amazing however I think that the title should be inline,
display: flex;
should fix this. Secondly the numbers in your card information should be bolded.In terms of your accessibility issues, your id should be unique.
In terms of your validation errors simply wrap all your content within a
<main>
tag.I hope that helps
Cheers Happy coding π
0 - @NaveenGumastePosted over 2 years ago
Hello Kamrul Hassan ! Congo π on completing this challenge
Let's look at some of your issues, shall we:
-
You can't use same
id
for more than one tag "this error is for thatDuplicate ID
". -
You for the
font-weight
for the numbers in bottom.
happy Codingπ
0 -
- @SamadeenPosted over 2 years ago
Great Work Khshakib!..
Here are my suggestions
-
You are only allowed to have a particular id name, some of your divs have duplicated id names
-
For responsiveness, flexbox is the best way to go.
Overall you did a great Job.. Cheers mate
0 -
- @Beats-AyushPosted over 2 years ago
Hi Kamrul Hassan,
Other than the Accessibility and HTML issues, a couple of things will get the look closer to the solution-
- A border-radius to the card.
- Appropriate font-family and font-weights.
- max-width to restrict the width of the card when you are going to mobile design.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord