Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Add the language attribute
lang = " "
to the html tag <html> and replace <div class="contain"> with the main tag to fix the accessibility and error issues. click here for more on web-accessibility and semantic htmlFor the color of the image, there is no need for a linear gradient, add a background-color of soft violet and background-blend-mode of multiply to .image.
.image{ background-image: url(); background-size: cover; background-color: hsl() background-blend-mode: multiply; opacity: 0.8; }
To center .container on the page using flexbox, replace justify-items with align-items and add min-height: 100vh to .contain
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forget ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.
- Every site should ALWAYS have ✅ a
main
element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.
More Info: 📚
- The “Get insights that help your business grow" is a heading ⚠️ in this component so it should be wrapped in a
heading
element.
- Do not uppercase❌ "companies", "templates" and "queries" in HTML as it is not accessible friendly. Instead you will want to style it in CSS.
- The statistics at the bottom are a list ⚠️, so it should be built using an
unordered List
element.
More Info: 📚
MDN <ul>: The Unordered List element
- ⚠️ Remove all the
br
elements you added; they are being used incorrectly.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord