Design comparison
SolutionDesign
Solution retrospective
I will apreciate any feedback.
Community feedback
- @EngineerHamzieyPosted over 2 years ago
Hello Ernesto Borges, Your solution looks great here are some suggestions:
- always add the language attribute to your
<html>
tag, it should look like<html lang="en">
, here en means English. - To make your website accessible for assistive technologies users, i.e to avoid accessibility issues, All Your page content should be contained by landmarks like
<header>, <main> ,<footer>, /*etc*/
. read more - alt on the decorative image can be left blank for better accessibility i.e use
<img class="img2" src="images/image-header-desktop.jpg" alt="">
NOT<img class="img2" src="images/image-header-desktop.jpg" alt="image-header-desktop">
- Any time you submit a solution, check if you have any accessibility or HTML issues, if yes, click the "view report" button, then on the "view report" page, click learn more under each issue, then fix it, and click the "generate new report" button.
- I just glanced through you html and observed you used pure divs , Read more on landmark elements
I hope this helped 😊
Marked as helpful0 - always add the language attribute to your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord