Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS ⚠️:
- This solution consists incorrect usage of
<h2>
so it can cause severe accessibility errors due to incorrect usage of level-two headings<h2>
- Every site must want only one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- In this solution there's
<h2>
element which is this<h2>Get Insights...</h2>
, you can preferably use<h1>
instead of<h2>
. Remember<h1>
provides an important navigation point for users of assistive technologies so we want to use it wisely
- So we want to add a level-one heading to improve accessibility
- Example:
<h1>Get <span>insights</span> that help your business grow.</h1>
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @lack21Posted over 1 year ago
Excellent work 👍, but I have some recommendations!
- Remove following styles from
.main
margin-top: 10%; margin-left: 10%; height: 70vh;
and add this instead
height: 400px
!- After that add these styles to the
body
display: grid; place-content: center; min-height: 100vh;
this should center the layout!
Marked as helpful0 - Remove following styles from
- @ajeetachalPosted over 1 year ago
Hey there! @lack21 First of all, I want to express my sincere gratitude for taking the time to review my project code and offering your valuable suggestions. It's always a pleasure to receive constructive feedback from someone who shares the same passion for learning and improving.
Your suggestions have given me new perspectives to consider, and I'm excited to explore the potential improvements they could bring to the project. I truly appreciate your keen eye for detail and your willingness to share your expertise.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord