Design comparison
Solution retrospective
Feedbacks are welcomed Thank you.
Community feedback
- @vanzasetiaPosted over 1 year ago
Hi there! π
I recommend importing both font families at the same time. It is possible to import both font families at the same time.
You should not skip heading levels. In other words, heading levels must always be in order to give structure to a page.
Those statistic numbers should not be headings. Also, use
<ul>
element to render the statistic content.Never use
px
unit for font sizes. Userem
orem
instead. Relative units such asrem
andem
can adapt when the users change the browser's font size setting. Learn more β Why you should never use px to set font-size in CSSI hope my suggestions help you. Happy coding! π
Marked as helpful1 - @frank-itachiPosted over 1 year ago
Hello there π. You did a good job!
I have some suggestions about your code that might interest you.
HTML π:
- Wrap the page's whole main content in the
<main>
tag. - The heading order is important in the html structure so try to always start your headings and/or titles with an
<h1>
tag and then you can increase by one if you need to use more headings in your html code. So replace the<h3>
tags by the<h2>
. - Since the mobile design has a different image, you can use the
<picture>
tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here
I hope you find it useful! ππ Above all, the solution you submitted is greatπ!
Happy
<coding />
π!Marked as helpful1 - Wrap the page's whole main content in the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord