Design comparison
SolutionDesign
Solution retrospective
Hey Guys, this is my solution for this challenge, I always unsure of my code are correct or not, any feedback are welcome
Community feedback
- @romila2003Posted about 2 years ago
Hi Rian,
Congratulations 🎉 for completing this challenge, your Stats Card component looks great, and it is great that you used flex to center the card. Also, it is great that you used the right semantic for your code. There are some issues/suggestions I want to address:
- Within your
section
tag that contains the pictures, there is apicture
tag. I would suggest removing thesection
tag and just wrapping the pictures with apicture
tag like you did assection
tags usually contain a header, anywhere betweenh2
toh6
. - I noticed that you took a desktop-first approach however I would strongly suggest you take a mobile-first approach since it will be easier for responsiveness and it is best practice to do.
Overall, great attempt and wish you the best for your future projects so keep coding 👍.
Marked as helpful1 - Within your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord