Stats preview card component using HTML5 and CSS3
Design comparison
Solution retrospective
Hello, I need feedback on the CSS and the responsiveness of the page, please
Community feedback
- @MojtabaMosaviPosted almost 3 years ago
1- Desktop and mobile view behave properly but there are some minor overflowing and overlapping issues main because of spacig of the stats is dependent of a flex property and padding being set using presentages, use some like rems to see the differece in behavior.
2- stats could be implemented using an unordered list.
Keep coding :=)
Marked as helpful0 - @omarmohy98Posted almost 3 years ago
Hi@eyagargah, wonderfully done! The code is remarkably responsive. Below is my feedback on potential improvements!
1.) Instead of <div class="card"> , let's replace that with <main> element. Doing so will give your code more semantic meaning, will allow screen readers to know this is your main content and Fix the issues appear in Accessibility Report.
2.) All of your images should have alt attribute with content within the quotations.
If you found my feedback helpful, please mark this comment as helpful. Wonderfully done. Happy coding!
Marked as helpful0@eyagargahPosted almost 3 years ago@omarmohy22 thank you so much for taking the time to comment great feedback I appreciate the helpful advice!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord