stats preview card component using HTML , SASS & Bootstrap

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The vh-100 utility class is used to define height: 100vh, But we want to use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  • So we want to use min-vh-100 Bootstrap utility class to define min-height: 100vh

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  Good job 👍, but I have a suggestion!

  • Remove width: 100% from the main, main is a block level element which by default takes full space available, so width: 100% does nothing here!

  Marked as helpful

  0