Design comparison
SolutionDesign
Community feedback
- @frank-itachiPosted almost 2 years ago
Hello there π. Congratulation for completing the challengeπ!
I have some suggestions about your code that might interest you.
HTML π:
- Wrap the
<div class="attribution">
section inside the<footer>
tag. - you could also use the
<picture>
tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here.
CSS π¨:
- Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here.
I hope you find it useful! π Above all, you did a good job!
Happy
<coding />
π!0 - Wrap the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord