Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
That it is at least close to the design and I will probably try harder next time to get it close enough.
What challenges did you encounter, and how did you overcome them?Implementing the design was my biggest challenge and I overcame it by just telling myself that it doesn't have to be pixel perfect.
What specific areas of your project would you like help with?Feedback.
Community feedback
- @Zy8712Posted 8 months ago
Your site looks great and code is easy to read. Nice work!
Some changes I'd suggest are:
- leaving the
alt
description on images empty (alt=""
). Descriptions for images are mainly used for images that convey some type of information. So decorative images that don't have any information can just have their descriptions be left blank - you should use a
<h1>
tag instead of an<h2>
tag as headings are supposed to be used in order from h1 to h6 without any skips. The headers come with default font sizes that can be changed using thefont-size
attribute
Hope you find this feedback useful 👍
Marked as helpful1@CardboardPLPosted 8 months ago@Zy8712 Thanks for the feedback! I updated my code to the suggestions you pointed out.
0 - leaving the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord