Design comparison
SolutionDesign
Community feedback
- @grace-snowPosted over 3 years ago
Hey
This looks great! Just a few improvements I can suggest ☺
- you need to put the 3 stats in meaningful html elements, not divs. I would probably use a list with 3 items for these
- font size can't be in px, use rem even on the base/body element
- your media query for Desktop kicks in very late. I would expect to see it from about 800px, maybe even earlier. Whenever there is room for the layout to change, thats when media query should start.
- check your image height. As it's using viewport units it goes very small on mobile landscape, so you may want to consider a different unit.
Good. Luck
Marked as helpful0@rnguecoPosted over 3 years ago@grace-snow Thank you for the feedback Grace! I will get on doing that.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord