Submitted 11 months ago
Stats preview card component using Container Queries, Flexbox and Grid
@seanbuckle
Design comparison
SolutionDesign
Solution retrospective
How could I improve the way in which I coded this?
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- The modifier in BEM changes the appearance or behavior of the block or element. The modifier isn't another level of nesting; for example, if you have a button with a red color and you've named it "button," if you want another button with the same styles but in blue, you should simply add "button--blue" to it.
- You've used variables in the
:root
selector and employed thevar
function, but SASS has its own syntax for variables that you could leverage. You can learn more about it here: SASS Variables Documentation
card__stats
could be effectively represented as a list of elements using<ul>
and<li>
instead of a <section> tag, as the <section> tag is typically used for grouping related content.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord