Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello again Marius, Congratulations on completing this challenge!
Nice solution and nice code! I can see that you paid a lot of attention to your code/design. If you don’t mind I’ve some tips for you:
I saw that you’ve used
id
to give the styling for your component, its not a good idea becauseid
its a too much specific selector used forforms
and Javascript code. Instead, useclass
for styling and let theid
for much specific stuff.It is not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later.
✌️ I hope this helps you and happy coding!
Marked as helpful0@ir4MPosted about 2 years ago@correlucas You're right, thank you :) Looking back, I'm surprised I didn't notice that myself. Have changed it.
1@correlucasPosted about 2 years ago@ir4M I discovered it recently too Marius, keep it up! Anyway your code its working fine and perfectly!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord